feat: SDKE-64 Improve mParticle.m test coverage in swift 3 #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BrandonStalnaker
left a comment
BrandonStalnaker
left a comment
There was a problem hiding this comment.
In general this all looks great. The only worrying thing is these static methods were public and put to use in the kits. Can you confirm no other kits were updated to use this static method? I'll make another PR to the rokt kit to not utilize this code. (Thankfully it hasn't been released yet)
BrandonStalnaker
approved these changes
Sep 17, 2025
Collaborator
BrandonStalnaker
left a comment
BrandonStalnaker
left a comment
There was a problem hiding this comment.
Code removed from the MPRokt kit and judging by my search it is not used elsewhere https://github.com/search?q=org%3Amparticle-integrations+mplog&type=code
denischilik
deleted the
feat/SDKE-64-improve-MParticle-m-Test-Coverage-in-Swift-3
branch
mparticle-automation
added a commit
that referenced
this pull request
Sep 18, 2025
# [8.39.0](v8.38.0...v8.39.0) (2025-09-18) ### Bug Fixes * Update Hashed Email Logic With Unassigned ([#401](#401)) ([c50b101](c50b101)) ### Features * SDKE-119 Create protocols for testability ([#402](#402)) ([12b636e](12b636e)) * SDKE-119 Create protocols for testability. Part 2 ([#403](#403)) ([6401e0c](6401e0c)) * SDKE-119 Create protocols for testability. Part 3 ([#404](#404)) ([9032458](9032458)) * SDKE-61 Extract and test callback logic. Part 1 ([#395](#395)) ([c3a7da9](c3a7da9)) * SDKE-61 Extract and test callback logic. Part 2 ([#396](#396)) ([2fb2490](2fb2490)) * SDKE-61 Extract and test callback logic. Part 3 ([#397](#397)) ([b6cd236](b6cd236)) * SDKE-61 Extract and test callback logic. Part 4 ([#398](#398)) ([3cf3c88](3cf3c88)) * SDKE-62 Refactor MPListenerController for Testability ([#400](#400)) ([cc843a5](cc843a5)) * SDKE-63-replace-logging-macros-with-swift-helpers ([#405](#405)) ([0ca4964](0ca4964)) * SDKE-64 Improve mParticle.m test coverage in swift ([#406](#406)) ([d4ef623](d4ef623)) * SDKE-64 Improve mParticle.m test coverage in swift 2 ([#407](#407)) ([b8d67ec](b8d67ec)) * SDKE-64 Improve mParticle.m test coverage in swift 3 ([#410](#410)) ([72a111c](72a111c))
Contributor
|
🎉 This PR is included in version 8.39.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 3 PR in the series aimed at improving the test coverage of mParticle.m. The first PR is #407
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)